Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Mail not queued when using no 'to' on the Facade #18147

Closed
tomcoonen opened this issue Feb 28, 2017 · 3 comments
Closed

[5.4] Mail not queued when using no 'to' on the Facade #18147

tomcoonen opened this issue Feb 28, 2017 · 3 comments

Comments

@tomcoonen
Copy link

  • Laravel Version: 5.4.13
  • PHP Version: 7.0
  • Database Driver & Version:

Description:

Mail is not queued when using no 'to' on the Facade, setting a 'to' on the Facade doesn't make sense when the recipient is always dependent on the data sent to the Mailable class like in the example below.

Steps To Reproduce:

Mail::send(new OrderPicked(Order::find(10000)));

@tomcoonen
Copy link
Author

I'm solving it now by putting a Notification in between, and for some e-mails that makes sense since they will probably get more channels than e-mail.
But from my point of view it would be good to fix the issue so you can only send an e-mail like described.

@KennedyTedesco
Copy link
Contributor

I believe it was fixed on this PR? #18144

@tomcoonen
Copy link
Author

@KennedyTedesco yes, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants