[5.4] Always put Mailable on queue if ShouldQueue contract exists

[KennedyTedesco]

Documentation says:

If you have mailable classes that you want to always be queued, you may implement the ShouldQueue contract on the class. Now, even if you call the send method when mailing, the mailable will still be queued.

With this change, even if I use the send() method, will be queued, because the ShouldQueue interface was implemented:

class OrderShipped extends Mailable implements ShouldQueue
{
    use Queueable, SerializesModels;

    // todo
}

Then:

Mail::send(new OrderShipped()); // Will be queued
Mail::queue(new OrderShipped()); // Will be queued

@taylorotwell Is this makes sense for you?

[tomcoonen]

@taylorotwell @KennedyTedesco Since you're putting a 'SendQueuedMailable' on the queue, which does

$mailer->send($this->mailable);

you're creating an endless loop that doesn't send anything..

[KennedyTedesco]

@tomcoonen Have you tested? How can I reproduce this? Because I have tested on my app Mail::send(new OrderShipped()); and all worked fine.

[tomcoonen]

@KennedyTedesco I have tested this, keeps queuing.
I simply added your commit to \Illuminate\Mail\Mailer locally to test:

    public function send($view, array $data = [], $callback = null)
    {
        if ($view instanceof MailableContract) {
            if ($view instanceof ShouldQueue) {
                return $view->queue($this->queue);
            }

            return $view->send($this);
        }

[KennedyTedesco]

@tomcoonen Got it. So, it's all good or we have any issue?

[tomcoonen]

@KennedyTedesco No good. Like I said, it keeps queuing without sending.

[KennedyTedesco]

@tomcoonen Now I see! I'll send a PR to fix this ASAP.