Custom error message not working

[begueradj]

Laravel Version

10.x

PHP Version

8.1

Database Driver & Version

MySql 8, Ubuntu 20.04

Description

I am using Laravel Breeze and I want to display a custom error message related to the password input during user registration.
But it is always the default error message that gets displayed.

Steps To Reproduce

In app/Http/Controllers/Auth/RegisteredUserController.php", I want to set a custom error message (please read the 2 comments):

public function store(Request $request): RedirectResponse
    {
        $messages = [
            // This custom message gets displayed properly
            'name.required' => 'We need your name',
            // This custom error message is not displayed.  The default one gets displayed, instead:
            'password.letters' => 'Your keyboard should have letters.', 
        ];
        $rules = [
            'name' => ['required', 'string'],
            'email' => ['required', 'string', 'lowercase', 'email', 'max:255', 'unique:'.User::class],
            'password' => ['required', 'confirmed', Password::min(3)->letters()]
        ];
        $request->validate($rules, $messages);

        $user = User::create([
            'name' => $request->name,
            'email' => $request->email,
            'password' => Hash::make($request->password),
        ]);

        event(new Registered($user));

        Auth::login($user);

        return redirect(RouteServiceProvider::HOME);
    }

From this source file and the documentation, what I did should work.

[driesvints]

Hi there,

Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

• Laracasts Forums
• Laravel.io Forums
• StackOverflow
• Discord
• Larachat
• IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!

Thanks.

[begueradj]

@driesvints Thank you for the feedback but I believe this is a bug.

[driesvints]

@begueradj try setting 'validation.password.letters' instead or else try a json translation file of The :attribute must contain at least one letter.

[begueradj]

Thank you.
I tried that too because I found it in the source code itself. But it did not work.
What I did is to run php artisan lang:publishand modified that message within validation.php file.
But I do not like the solution I did.

I am looking for something similar to what the documentation says about non built-in methods.
The documentation does not cover anything about this (built-in methods). If they are supposed to work in the classic way, then this is clearly a bug.

[driesvints]

@begueradj can you try this?

$messages = [
    'password' => ['letters' => 'Your keyboard should have letters.'], 
];

[begueradj]

I just tried what you suggested: no message is displayed in this case.

[driesvints]

I don't know what's up unfortunately.. appreciating any help with this.

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[smkbd]

@begueradj
Password::min(3)->letters() what's the namespace for it? Is it a custom Validation Rule? If so, you can add the validation message in that particular Rule class. If not, you can create a custom validation rule to achieve what you want.
https://laravel.com/docs/10.x/validation

It seems 'password.letters' is not present in the validation error message bag. That's why you are not getting the value for it.

[rcknr]

@begueradj It appears that Illuminate\Validation\Rules\Password doesn't support custom messages for some of its validations. As you can see in the source file you've linked some rules are added after Validator is made and their messages are retrieved solely through translations. So only thing you could do is use another validator. For example:

$messages = [
    'password' => ['regex' => 'Must contain letters']
];
$request->validate([
    'password' => ['required', 'confirmed', 'regex:/\pL/u'],
], $messages);

[rcknr]

One can argue that the Password validation rule should use addFailure() method instead of errors()->add() to use existing message retrieval instead of bypassing it.

[begueradj]

Thank you @rcknr What you said should be added to the official documentation then. Otherwise, implicitly, according to the official documentation, we could customize error messages of all validation rules.

[rcknr]

@begueradj My changes were released in 10.33.

[begueradj]

You did a wonderful work @rcknr
Thank you so much for your efforts.
That is a precious contribution you made for the community.
Thank you also for having notified me.