[10.x] Custom messages for Password validation rule

[rcknr]

As described in #48866 Password validation rule did not support custom messages provided through the validator and had validation messages in code.

[taylorotwell]

Your PR will break applications that have not added the password translation lines to their validation language file.

[rcknr]

@taylorotwell This shouldn't be a problem since default translations are provided with the framework in src/Illuminate/Translation/lang/en/validation.php.

[driesvints]

@rcknr draft PRs aren't reviewed. Please mark this as ready for review if you need one.

[rcknr]

@driesvints it was and is ready. There was a point about translation which I addressed in a comment above. What else can I do?

[driesvints]

@rcknr Press the "ready for review" button 😉

[rcknr]

@driesvints Done. To address @taylorotwell's point: validation messages for passwords are part of the framework. One potential problem I see is when somebody has already used a validation message itself as a translation key (not as slug key e.g. password.letters). This could be addressed by translating the message before it's processed by the validator. In any case I doubt it was good idea to put these messages into the rule in the first place.

[begueradj]

good job @rcknr 👍

[ax-gli]

could someone tell me where the translation happens? Thank you! I have test cases like these, but they no longer work, should I just change it to the error type? laravel will take care of the translation? Thank you!

class PasswordTest extends TestCase
{
    use PasswordValidationTestUtilities;

    const MIN_REQ_MSG = "The password must be at least 12 characters.";
    const MAX_REQ_MSG = "The password must not be more than 64 characters.";
    const NUM_REQ_MSG = "The password must contain at least one number.";
    const SYM_REQ_MSG = "The password must contain at least one symbol.";
    const LETTER_REQ_MSG = "The password must contain at least one uppercase and one lowercase letter.";

     * @dataProvider providePasswordAndMessage
     */
    public function testComplexityMessages(string $password, string $msg)
    {
        $this->mockPasswordUncompromisedVerifier();
        $validator = Validator::make(['password' => $password], ['password' => PasswordRule::default()]);
        self::assertFalse($validator->passes());
        self::assertEquals($msg, $validator->errors()->get('password')[0]);
    }

    public function testAllRequirementsReturned()
    {
        $msg = join(" ", [
            self::MIN_REQ_MSG,
            self::LETTER_REQ_MSG,
            self::SYM_REQ_MSG,
            self::NUM_REQ_MSG,
        ]);
        $this->mockPasswordUncompromisedVerifier();
        $validator = Validator::make(['password' => 'password'], ['password' => PasswordRule::default()]);
        self::assertFalse($validator->passes());
        self::assertEquals($msg, join(" ", $validator->errors()->get('password')));
    }

    public static function providePasswordAndMessage(): array
    {
        return [
            'letter_required' => ['i-Am-missing-a-number', self::NUM_REQ_MSG],
            'symbol_required' => ['iAmMissingASymbol9', self::SYM_REQ_MSG],
            'uppercase_required' => ['i-am-missing-uppercase-1', self::LETTER_REQ_MSG],
            'lowercase_required' => ['I-AM-MISSING-LOWERCASE-1', self::LETTER_REQ_MSG],
            'min_required' => ['2Small_', self::MIN_REQ_MSG],
            'max_required' => [
                '2Large_aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
                self::MAX_REQ_MSG
            ],
        ];
    }

[bradietilley]

@taylorotwell This shouldn't be a problem since default translations are provided with the framework in src/Illuminate/Translation/lang/en/validation.php.

It broke my tests. All g though, easy fix.