Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix blade parent keyword escaping #11627

Closed
wants to merge 2 commits into from

Conversation

Ruby184
Copy link
Contributor

@Ruby184 Ruby184 commented Dec 30, 2015

This PR is fix for issue #10068 and it's trying to properly handle @parent keywords in Blade sections and ensure proper section extending. The solution is hardly based on previously reverted commit #10122 with a few tweaks.

TODO list:

  • Fix original issue [5.1] [5.3] @parent tag is not escaping #10068.
  • Add test to ensure @parent keyword is properly handled.
  • Edit test for multiple section extending to ensure we will not introduce bugs like @parent totally breaks since 5.1.13 #10156.
  • Fix @append behaviour to properly handle parent marks.
  • Add tests for section appending.
  • Add tests for section overwriting.
  • Confirmation from @abhimanyusharma003 @parent keyword is properly escaped.
  • Confirmation form @atmediauk this fix is working as expected and has no side effects for him.

Thank you guys. Special thanks to @mspiderv for helping me with figuring out how to fix it and @dmgawel for previous try to fix this issue.

@taylorotwell
Copy link
Member

What is the difference between $parentMarks and $parentMarksLast?

@taylorotwell
Copy link
Member

Closing pending lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants