Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fixes for redis queue driver #13035

Merged
merged 1 commit into from
Apr 25, 2016

Conversation

halaei
Copy link
Contributor

@halaei halaei commented Apr 6, 2016

Changes

Upgrade guides required

The changes require Redis >= 2.6.0. I don't think it will be an issue, since 2.6.0 itself is too old! Also, Redis eval command should not be disabled in the Redis configuration file, which I don't think is a big deal - why should somebody do that.

@GrahamCampbell GrahamCampbell changed the title [5.3] fixes for redis driver squashed to one commit [5.3] Fixes for redis queue driver Apr 6, 2016
@taylorotwell
Copy link
Member

Can you explain what the $reserved parameter passed to the constructor is for?

@halaei
Copy link
Contributor Author

halaei commented Apr 6, 2016

$reserved is the json serialization of the reserved job. The string is not the same as the original job anymore. It is computed inside the LUA script and we can't expect PHP to be able to compute that using json_encode() in the exact way. The exact value of the $reserved string is required for delete and release operations.

@taylorotwell taylorotwell merged commit 3b103d3 into laravel:master Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants