[5.3] Fixes for redis queue driver #13035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
migrateExpiredJobs()
usingeval
instead of watch-multi-exec (check and set) transactions to prevent issue Redis queue driver may never pop delayed jobs if the push rate is high #12653.attempts
counter when reserving job, instead of when releasing it, so that fatal errors be considered as tries.Upgrade guides required
The changes require Redis >= 2.6.0. I don't think it will be an issue, since 2.6.0 itself is too old! Also, Redis eval command should not be disabled in the Redis configuration file, which I don't think is a big deal - why should somebody do that.