Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Resources helper relies on Application defined resources path #15095

Merged
merged 1 commit into from
Aug 29, 2016
Merged

[5.3] Resources helper relies on Application defined resources path #15095

merged 1 commit into from
Aug 29, 2016

Conversation

peterfox
Copy link
Contributor

I and I'm sure a few others use different paths for where they store their resources in their Laravel projects, as the resources_path function has been added recently it would be nice if it relied on the Application instance rather than being hard coded.

With more service providers (Pagination, Spark, Passport) publishing assets and views it would be preferable if the application's configuration could define where these get installed as currently it always ends up in resources. This would also be of benefit for backwards compatibility should things change in the future.

@taylorotwell taylorotwell merged commit 151f76f into laravel:5.3 Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants