Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Make Storage::delete() act like Filesystem::delete() #15308

Merged
merged 1 commit into from
Sep 7, 2016
Merged

[5.3] Make Storage::delete() act like Filesystem::delete() #15308

merged 1 commit into from
Sep 7, 2016

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Sep 6, 2016

The current implementation will always return true even if one of file(s) weren't deleted unlike the delete method in Filesystem.

Note: This can be considered a breaking change, if so we can just change to master if the change is desirable.

@taylorotwell taylorotwell merged commit e68358d into laravel:5.3 Sep 7, 2016
@tillkruss
Copy link
Contributor

Dude, I love your clear commit messages and PR titles : )

@themsaid themsaid deleted the adapterdelete branch September 8, 2016 15:54
@themsaid
Copy link
Member Author

themsaid commented Sep 8, 2016

@tillkruss haha trying to keep everything clear :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants