Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Added with* to Mailable #15316

Merged
merged 2 commits into from
Sep 7, 2016
Merged

[5.3] Added with* to Mailable #15316

merged 2 commits into from
Sep 7, 2016

Conversation

jbrooksuk
Copy link
Member

@jbrooksuk jbrooksuk commented Sep 7, 2016 •
edited
Loading

Basically, just a copy and paste from Illuminate\View\View. I don't see any tests for the Mailable class at the moment though.

@jbrooksuk jbrooksuk changed the title Added with* to Mailable [5.3] Added with* to Mailable Sep 7, 2016
@ConnorVG
Copy link
Contributor

ConnorVG commented Sep 7, 2016

add dis shit

💯

GrahamCampbell
GrahamCampbell reviewed Sep 7, 2016
View reviewed changes
src/Illuminate/Mail/Mailable.php
@@ -2,6 +2,7 @@

namespace Illuminate\Mail;

use BadMethodCallException;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort by length plz

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@taylorotwell taylorotwell merged commit ae86295 into laravel:5.3 Sep 7, 2016
@jbrooksuk jbrooksuk deleted the mailable-view branch September 7, 2016 13:52
@jbrooksuk jbrooksuk restored the mailable-view branch February 21, 2017 16:28
@jbrooksuk jbrooksuk deleted the mailable-view branch February 12, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrooksuk @ConnorVG @GrahamCampbell @taylorotwell