Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] New object syntax for the rule in #15923

Merged
merged 1 commit into from
Oct 15, 2016

Conversation

sileence
Copy link
Contributor

@sileence sileence commented Oct 15, 2016

I've found myself doing 'in:'.implode(',', $values) because I have the $values var and it's an array already (located in the config, etc.) and then having to add a similar helper to my project. So I think this rule will be useful as well.

@taylorotwell taylorotwell merged commit 2db4a9d into laravel:5.3 Oct 15, 2016
@tillkruss
Copy link
Contributor

@sileence: While you're at it, could you add the not_in rule as well?

@mnabialek
Copy link
Contributor

@sileence Thanks. It's what I was going to propose too.

@GrahamCampbell GrahamCampbell changed the title [5.3] [proposal] New object syntax for the rule in [5.3] New object syntax for the rule in Oct 17, 2016
bepsvpt pushed a commit to bepsvpt-fork/framework that referenced this pull request Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants