Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Fix foreign key issue when primary key is not 'id' #16394

Closed
wants to merge 1 commit into from
Closed

[5.3] Fix foreign key issue when primary key is not 'id' #16394

wants to merge 1 commit into from

Conversation

srmklive
Copy link
Contributor

Fixes #16370 which describes scenario when getForeignKey method error when the specified primary key for a model is not id.

Fix originally suggested by @ElMatella.

@shadoWalker89
Copy link
Contributor

Maybe this should go in 5.4 ? cuz it could be breaking

@srmklive
Copy link
Contributor Author

@GrahamCampbell @themsaid @taylorotwell Should this go into 5.4?

@ntzm
Copy link
Contributor

ntzm commented Nov 14, 2016

Yes it should, I can see this breaking in many cases

@srmklive
Copy link
Contributor Author

Moving this PR over to 5.4

@srmklive srmklive closed this Nov 14, 2016
@srmklive srmklive mentioned this pull request Nov 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srmklive @shadoWalker89 @ntzm