[5.3] Create custom Collection also on empty page #16547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmichot
reviewed
Nov 25, 2016
| @@ -1663,7 +1663,7 @@ public function paginate($perPage = 15, $columns = ['*'], $pageName = 'page', $p | |||
|
|
|||
| $total = $this->getCountForPagination($columns); | |||
|
|
|||
| $results = $total ? $this->forPage($page, $perPage)->get($columns) : []; | |||
| $results = $total ? $this->forPage($page, $perPage)->get($columns) : collect(); | |||
There was a problem hiding this comment.
@vlakoff should it not be a new \Illuminate\Database\Eloquent\Collection ?
There was a problem hiding this comment.
It's the query builder, not eloquent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #16528. Makes sense that Eloquent Builder passes the same class to LengthAwarePaginator whether the page is empty or not.
This would have worked too:
Though in doubt, I kept the optimization from #14188.
The change in Query Builder is not mandatory because LengthAwarePaginator already converts to a base Collection, but it's more straightforward this way.