[5.3] Allow Broadcasting a notification now instead on queue

[themsaid]

This is an attempt to allow broadcasting notifications immediately instead of doing it via queue, to achieve this you'll need to add the following method in your Notification class:

public function broadcastNow(){
    return true;
}

This will have the BroadcastNotificationCreated $connection set to sync so that the queue manager use it as the connection name.

---

Update

Added a new BroadcastMessage that can be returned from toBroadcast, this new class has a now() method that we use to update the connection name.

public function toBroadcast()
{
    return (new BroadcastMessage([...]))->now();
}

[GrahamCampbell]

Why should we assume the sync connection is called "sync". We can name it whatever we want? It's only the driver which is "sync", not the connection.

[themsaid]

I think we assume the sync driver is called sync in multiple areas in the framework already, for example: https://github.com/laravel/framework/blob/5.3/src/Illuminate/Broadcasting/BroadcastManager.php#L107

[GrahamCampbell]

Looks like a bit of a bug tbh.

[GrahamCampbell]

Maybe we need to re-think the queue config in 5.4, and have a default "queue queue", and a default "sync queue"?

[themsaid]

That sounds like a good solution to me.

[JosephSilber]

Is there no way we can use the ShouldQueue interface here instead?

[taylorotwell]

I think it might be a little cleaner to have a BroadcastMessage(array)->now() construct.

[taylorotwell]

In real usage I think it would look something like:

return new BroadcastMessage($this->toArray())->now();

[taylorotwell]

And then the BroadcastChannel would properly handle that message type in getData.

[taylorotwell]

Tweaked this to just use Queueable trait.

[tillkruss]

This is probably worth mentioning in the docs.