Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Fixed broken event interface listening #16877

Merged
merged 3 commits into from
Dec 20, 2016
Merged

[5.3] Fixed broken event interface listening #16877

merged 3 commits into from
Dec 20, 2016

Conversation

GrahamCampbell
Copy link
Member

Unfortunately, array_merge_recursive discards the keys, so the previous implementation didn't work properly with priorities.

Before:
image

After:
image

@GrahamCampbell GrahamCampbell changed the title [5.3] Fixed broken event interface listening [5.3] [WIP] Fixed broken event interface listening Dec 20, 2016
@GrahamCampbell GrahamCampbell changed the title [5.3] [WIP] Fixed broken event interface listening [5.3] Fixed broken event interface listening Dec 20, 2016
@sisve
Copy link
Contributor

sisve commented Dec 20, 2016

This probably deserves some tests. </subtle hint>

@GrahamCampbell
Copy link
Member Author

Yeh, I already wrote some tests, but they just check if the handlers are fired, rather than what order they're fired in. :/

@taylorotwell taylorotwell merged commit d744b01 into 5.3 Dec 20, 2016
@taylorotwell taylorotwell deleted the event-fix branch December 23, 2016 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrahamCampbell @sisve @taylorotwell