Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Allow base collections in BelongsToMany::sync #16882

Merged
merged 2 commits into from
Dec 20, 2016
Merged

[5.3] Allow base collections in BelongsToMany::sync #16882

merged 2 commits into from
Dec 20, 2016

Conversation

sebastiandedeyne
Copy link
Contributor

Currently sync throws an error when providing a base collection object as your set of id's.

This method allows ->sync(collect([1, 2, 3])).

Since there's no type hint, and it currently throws an error—so it can't accidentally be done—I thinkthis change is non-breaking.

@taylorotwell taylorotwell merged commit 7baa075 into laravel:5.3 Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants