[5.4] Use namespaced PHPUnit TestCase #17058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coding standards fixes
|
Wonder why it fails on |
|
I've bumped the minimum phpunit version on your PR to 5.7.0, to get all the "forward compatibility" commits in phpunit 5. |
|
Tests should pass now I think. |
|
NB The problem was that, because autoloading is case sensitive, and PHPUnit 5.4.0->5.4.2 used lowercase namespace, then the uppercase version wasn't matched. |
Didn't know about that, thanks for clearing that up. |
More specifically: autoloading is case sensitive on a case sensitive filesystem. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to the namespaced
PHPUnit\Framework\TestCaseclass fromPHPUnit_Framework_TestCasein preparation for PHPUnit 6.0 (already available in version 5).See this tweet by @sebastianbergmann: https://twitter.com/s_bergmann/status/814846275099181056