-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.4] Change how frequencies are tested for schedule #17086
Conversation
/** | ||
* @test | ||
*/ | ||
function every_minute() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does't match the style of our other tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, correct you are. I'll change them to match the format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Not that there's anything wrong with that format, it looks pretty nice, but, just not for laravel/frameworks tests please. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, its my macro for creating tests. I use it for my personal tests, and out of habit used them here. My mistake, should have noticed that :)
@GrahamCampbell Made that change. Thoughts on https://github.com/laravel/framework/pull/17086/files#diff-ff04bb655c1b51776934f8e56cdeb527R19 ? |
So these new tests require PHP 7? |
@taylorotwell Not anymore. The original commit did, and I would strongly like to alter how the test works in Laravel 5.5+ when PHP 7.0+ is a requirement to eliminate an unnecessary mock, but for now, it works in PHP 5.6+ |
There is a test written for the |
@taylorotwell Please can you add in the test in my first message above for |
A change to how schedules are tested for their expression.
I opted to not use mocks, since Cache is not required for the tests to happen.
This, unfortunately, requries PHP 7.0+ to be done in this way, so if you wish to have support for the 5.6+, then this will be required:
If #17084 gets accepted, then this test is required:
If #17085 gets accepted, then this test is required: