[5.3] Add HourlyAt() option for scheduled events #17168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Jan 5, 2017
| @@ -345,6 +345,17 @@ public function hourly() | |||
| } | |||
|
|
|||
| /** | |||
| * Schedule the event to run hourly at a given offset in the hour. | |||
| * | |||
| * @param string $offset | |||
There was a problem hiding this comment.
Yeah - good pickup. Fixed now
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple extension of the
hourlyfunction to allow for an minute offset.Basically if you have a few scheduled events you want to run hourly - it is nice to be able to offset them from 0 to a different 'minute' - so they dont all run simultaneously at
:00and put unnecessary load on the server.