[5.4] Normalize PhpRedis GET/MGET call #17196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
previously requested changes
Jan 8, 2017
| @@ -18,6 +18,19 @@ public function __construct($client) | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the value of the given key. | |||
| * | |||
| * @param string $key | |||
tillkruss
force-pushed
the
normalize-phpredis
branch
from
e1056eb to
a09a46a
Compare
tillkruss
force-pushed
the
normalize-phpredis
branch
from
a09a46a to
daba073
Compare
tillkruss
changed the title
|
Honestly I think I'll just document that false and null should not be cached. Or, if you need to cache such a value to wrap it in an array data structure or something like ['foo' => null]. |
|
Works for me. |
tillkruss
force-pushed
the
normalize-phpredis
branch
from
daba073 to
f352597
Compare
|
Fixed conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17188.