Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Show seed output prior to running, instead of after #17318

Merged
merged 1 commit into from
Jan 13, 2017
Merged

[5.3] Show seed output prior to running, instead of after #17318

merged 1 commit into from
Jan 13, 2017

Conversation

reinink
Copy link
Contributor

@reinink reinink commented Jan 13, 2017

Currently the database seeder shows its output prior to running the seed class. For example:

# runs seed class UserSeeder
Seed: UserSeeder

This is a simple change that proposes to show the output before running the seeder:

Seeding: UserSeeder
# runs seed class UserSeeder

This may seem minor, but on a project with long-running seeds it's difficult to know which seed is currently running. It's even more annoying if a seed breaks (for whatever reason), you don't actually know which seed it was (without pulling up the code and looking at the seed order).

image

@GrahamCampbell GrahamCampbell changed the title Show seed output prior to running, instead of after. [5.3] Show seed output prior to running, instead of after Jan 13, 2017
@taylorotwell taylorotwell merged commit c43e7a6 into laravel:5.3 Jan 13, 2017
@reinink reinink deleted the patch-1 branch January 13, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants