Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Add salutation option to SimpleMessage notification #17422

Closed
wants to merge 1 commit into from
Closed

[5.3] Add salutation option to SimpleMessage notification #17422

wants to merge 1 commit into from

Conversation

seblavoie
Copy link
Contributor

By default 'Regards,' is displayed as a salutation at the end of notification emails. Much like the pull #15108 added an optional greeting() method, I think that would make sense to also add one for the salutation at the end. What do you think?

public function toMail($notifiable)
{
    return (new MailMessage)
                ->line('The introduction to the notification.')
                ->action('Notification Action', 'https://laravel.com')
                ->line('Thank you for using our application!');
                ->salutation("Cheers!")
}

@GrahamCampbell GrahamCampbell changed the title Add salutation option to SimpleMessage notification [5.3] Add salutation option to SimpleMessage notification Jan 19, 2017
@GrahamCampbell
Copy link
Member

Probably should go to 5.4, at this point.

@taylorotwell
Copy link
Member

I agree let's move this to 5.4 if you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants