[5.4] Add Schema to notifications.stub for consistency #17664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
use Illuminate\Support\Facades\Schema;to the stub file for notification tables.This is for consistency - as every other stub migration generated by the framework includes this. Same as
make:migrationalso includes this in all generated migration files.The alternative - as it currently works without including the Facade - should we remove
use Illuminate\Support\Facades\Schema;from all stubs instead? I tried it and it works on my fresh copy of5.4- but I wasnt sure if there might be unintended consequences (perhaps with namespaced migrations?)