[5.4] TrimString Middleware bugfixes (using strict comparison instead of loose comparison) #17741

jeffersonsetiawan · 2017-02-03T07:14:09Z

I found bug on the laravel framework on TrimString Middleware. It used loose comparison.

For Example:

<html>
<body>
<form method="POST">
    <input type="text" name="foo[]">
    <input type="text" name="foo[]">
    <input type="submit" value="submit">
</form>
</body>
</html>

If we use the loose comparison, the first input will not be trimmed because method:
in_array(0, $this->except)

always return true (comparing 0 with string).

if we use strict comparison (by adding true for the 3rd argument), it will be fixed.
in_array($key, $this->except, true)

…son)

TrimString bugfixes (using strict comparison instead of loose compari…

9e89f15

…son)

jeffersonsetiawan changed the title ~~TrimString Middleware bugfixes (using strict comparison instead of loose comparison)~~ [5.4] TrimString Middleware bugfixes (using strict comparison instead of loose comparison) Feb 3, 2017

taylorotwell merged commit a67aeeb into laravel:5.4 Feb 3, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.4] TrimString Middleware bugfixes (using strict comparison instead of loose comparison) #17741

[5.4] TrimString Middleware bugfixes (using strict comparison instead of loose comparison) #17741

jeffersonsetiawan commented Feb 3, 2017 •

edited

Loading

[5.4] TrimString Middleware bugfixes (using strict comparison instead of loose comparison) #17741

[5.4] TrimString Middleware bugfixes (using strict comparison instead of loose comparison) #17741

Conversation

jeffersonsetiawan commented Feb 3, 2017 • edited Loading

jeffersonsetiawan commented Feb 3, 2017 •

edited

Loading