[5.4] Properly set the JSON payload of FormRequests #17760
Merged
+13
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR highlights the cause of the issue experienced in #17753
When the transformation middleware runs,
$request->json()
is called and the returned parameter bag is replaced with the transformed one, later calls to->json()
presents the modified bag not the original one: https://github.com/laravel/framework/blob/5.4/src/Illuminate/Http/Request.php#L294For form requests when we initialise it we pass the original content:
framework/src/Illuminate/Foundation/Providers/FormRequestServiceProvider.php
Line 56 in 7212b1e
So when
->json()
is called on the form request, it'll read the original content of the request and thus why the transformation won't take effect.In this PR I explicitly set the
json
bag of the form request from the json bag of the original request, this way->json()
won't have to look into the content since there's already a bag present.