[5.4] Unencodable casted data in models is silently discarded #17804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
lucasmichot
reviewed
Feb 7, 2017
| * @param mixed $key | ||
| * @param string $message | ||
| * @return static | ||
| * @internal param mixed $key |
There was a problem hiding this comment.
Not sure @internal is necessary
There was a problem hiding this comment.
@lucasmichot Agreed. It slipped by me as I was renaming the parameter. I'll correct in a second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just discovered the hard way that data in a casting attribute that fails to be json encoded, such as iso-8859-1 encoded text, will silently be discarded when saving the model.
This PR will check the result of the encoding and throw a JsonEncodingException with a descriptive error message if encoding fails.