[5.4] Allow configuration of Faker locale through config #17895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
changed the title
|
But why create a new config, if you can do it yourself? example |
|
Because it's easier than making people override the singleton registration themselves, and as per the internals discussion there's at least a bit of interest in it. |
|
Well, in general, I like the idea. |
|
Thanks for this @dwightwatson @taylorotwell , makes it much more convenient! May even encourage people to use faker with seeders more, as I have started doing 😄 |
clemblanco
added a commit
to clemblanco/laravel-laravel
that referenced
this pull request
Oct 2, 2018
As per [that PR](laravel/framework#17895) and [the documentation](https://laravel.com/docs/5.6/database-testing#writing-factories), I wanted to make sure this was present in the `app/config.php` out of the box. It's a great thing and I'm sure people will be happy to use it rather than overriding the singleton registration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to #17887, this grabs an adjustment to the Faker locale through the configuration. I went with
envthe first time as I thought it wouldn't matter much in development/test environments.Here I'm using
app.faker_localeas I'm not sure if any of the other standard configuration files are a better fit for this setting. Let me know if you would prefer a different name/location.I'm happy to make the PR to
laravel/laravelif this gets merged and you want it in the app boilerplate.