Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #18026 #18027

Closed
wants to merge 2 commits into from
Closed

Fix #18026 #18027

wants to merge 2 commits into from

Conversation

phackwer
Copy link
Contributor

#18026

PostgreSQL: improve table existence check (or assume default schema as "public")

@@ -16,6 +16,8 @@ public function hasTable($table)
$schema = head($schema);
}

$schema ? $schema : 'public';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually do anything does it? You aren't assigning the result to a variable

@taylorotwell
Copy link
Member

Your code doesn't do anything.

@phackwer
Copy link
Contributor Author

Ooops, you're right. I will set the $schema variable, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants