Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Add includeWhen directive #18047

Closed
wants to merge 1 commit into from
Closed

[5.4] Add includeWhen directive #18047

wants to merge 1 commit into from

Conversation

jbrooksuk
Copy link
Member

@jbrooksuk jbrooksuk commented Feb 21, 2017

This is a directive that shortens:

@if ($user->ownsPost($post)
@include('posts.edit-controls', ['post' => $post])
@endif

to...

@includeWhen($user->ownsPost($post), 'posts.edit-controls', ['post' => $post])

@taylorotwell
Copy link
Member

This was merged. Not sure why it's not detecting.

@driesvints
Copy link
Member

@taylorotwell commit hash got changed when you rebased. That's probably the reason.

@driesvints
Copy link
Member

Not that commit authors are still kept as is. You're just now indicated as the comitter.

@jbrooksuk jbrooksuk deleted the include-when branch February 22, 2017 16:20
@seanthebean
Copy link

Found the commit that added this into the 5.4 branch, just for traceability: 5fe39aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants