[5.4] Use fromRawAttributes when creating a newPivot #18127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casting attributes stored as JSON don't work properly when using a pivot model and setting the
$casts
property.In 5.2 fromRawAttributes method was added to manually resolve this issue. #13294
When using the new "using" method, for example:
$this->belongsToMany(Team::class, 'user_teams', 'user_id', 'team_id')->using(UserTeamPivot::class)
, the JSON is still encoded twice. It would be great if this could be changed so thefromRawAttributes
method is used.When using the
fromRawAttributes
method this is resolved.