Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Fix deletes with JOIN while using table Aliases #18156

Closed
wants to merge 2 commits into from
Closed

[5.4] Fix deletes with JOIN while using table Aliases #18156

wants to merge 2 commits into from

Conversation

themsaid
Copy link
Member

Fixes #18098

@fernandobandeira
Copy link
Contributor

This should be happening with SqlServer too since it's the same piece of code, maybe we should fix there too...

@themsaid
Copy link
Member Author

@fernandobandeira I'm not familiar with SqlServer, do you mind if you point me to the right place in docs?

@fernandobandeira
Copy link
Contributor

Docs

DELETE spqh  
  FROM  
               Sales.SalesPersonQuotaHistory AS spqh  
    INNER JOIN Sales.SalesPerson             AS sp  ON spqh.BusinessEntityID = sp.BusinessEntityID  
  WHERE  
    sp.SalesYTD > 2500000.00;  

Basically the same, just edit this function when testing you'll need to use [users] instead of `users`, just change that the query should be the same...

@themsaid
Copy link
Member Author

@fernandobandeira just pushed a commit.

@themsaid themsaid changed the title [5.4] Fix MySQL deletes with JOIN while using table Aliases [5.4] Fix deletes with JOIN while using table Aliases Feb 28, 2017
@taylorotwell
Copy link
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants