[5.4] Handle missing or malformed config/app.php file #18466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $files = $this->getConfigurationFiles($app); | ||
|
|
||
| if (! isset($files['app'])) { | ||
| throw new \Exception('Unable not load the config/app.php file.'); |
There was a problem hiding this comment.
Minor nitpick. This message should be "Unable to load the config/app.php file."
GrahamCampbell
requested changes
Mar 24, 2017
| $files = $this->getConfigurationFiles($app); | ||
|
|
||
| if (! isset($files['app'])) { | ||
| throw new \Exception('Unable to load the config/app.php file.'); |
There was a problem hiding this comment.
Normally, we import things. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the
config/app.phpfile was missing or corrupted you get aPHP Fatal error: Maximum function nesting level of 'x' reached, this is becauseLogServiceProvider::configureHandler()will call itself recursively since it has$this->{'configure'.ucfirst($this->handler()).'Handler'}($log);In case the app.php file couldn't be loaded
$this->handler()will returnnull, causing the method to call itself.In this PR I'm throwing an exception in case the
app.phpconfiguration file wasn't found, and if it was found but malformed I made sure Laravel can boot without it and be able to render the exception & log it.