[5.4] JsonResponse unsupported type error handling if flag set

[0xb4lint]

Currently, Illuminate\Http\JsonResponse does not support JSON_PARTIAL_OUTPUT_ON_ERROR flag check on json_encode() error.

If the JsonResponse constructor $data argument contains a resource (maybe deep inside in an error stack - $exception->getTrace()) there is an InvalidArgumentException thrown (because of only the json_last_error() is checked).

According to PHP Docs there is a flag (JSON_PARTIAL_OUTPUT_ON_ERROR) for generating NULL values on json_encode() error - such as resource encoding.

JSON_ERROR_UNSUPPORTED_TYPE (integer)
A value of an unsupported type was given to json_encode(), such as a resource. If the JSON_PARTIAL_OUTPUT_ON_ERROR option was given, NULL will be encoded in the place of the unsupported value. Available since PHP 5.5.0.

So the expected behavior is no InvalidArgumentException is thrown if the value of json_last_error() is JSON_ERROR_UNSUPPORTED_TYPE and the JSON_PARTIAL_OUTPUT_ON_ERROR flag is set (because the generated JSON is valid).

[taylorotwell]

This line is pretty hard to read. Is it possible to break it down into something simpler?

[0xb4lint]

@taylorotwell you're absolutely right, please check it ;)

[taylorotwell]

I'm sorry this conditional is still basically unreadable. I think it needs some of the not conditions reversed and maybe the whole method renamed.

[taylorotwell]

I reversed the whole conditional and renamed the method. Much easier to understand. Thanks.

[0xb4lint]

Thank you @taylorotwell! ;)