[5.4] Fix Queue Prefix bug #18982
Merged
[5.4] Fix Queue Prefix bug #18982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well that's frustrating. |
|
Yeah. I'm trying to think of a good test to avoid regression? |
|
I don't know. Anything really. I don't want to make another release until we confirm this is fixed. @browner12 |
|
@laurencei in my case this fix works with Beanstalk! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The queue prefix introduced in
5.4.20from here (#18860) is broken and does not allow queue processing. This PR should fix issue #18978The reason is the queue driver is prefixing the
prefixon all queues - which is correct. However, currently when you runqueue:work, it is also prefixing the queue, before passing it to the driver, which adds another prefix:prefix-prefix-defaultIt is even worse for
queue:listen- which prefixes, passes it toqueue:work, adds another prefix, and then passes it to the driver:prefix-prefix-prefix-defaultThis PR removes the prefixing from the worker & listener. They dont need to worry about prefixing - but that is handling by the drivers upon receiving a queue name.
There is also a second bug specifically related to the database queue driver. It adds another prefix during the table lookup unneccessarily, resulting in an extreme instance of:
prefix-prefix-prefix-prefix-defaultI've done some initial testing on this PR and it all seems to work on my integration tests. But feel free to test some more.