Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Route isName #19227

Merged
merged 3 commits into from
May 16, 2017
Merged

[5.4] Route isName #19227

merged 3 commits into from
May 16, 2017

Conversation

decadence
Copy link
Contributor

@decadence decadence commented May 16, 2017 •
edited
Loading

Added isName method for Route instance to avoid some repetitive code.
Renamed test name because Request method isRouteName (#19202) became routeIs after 26681eb

@decadence
Copy link
Contributor Author

decadence commented May 16, 2017 •
edited
Loading

One question is comparing has to be === or ==? Because routeIs does it one way while currentRouteNamed uses another.

@taylorotwell taylorotwell merged commit e06101d into laravel:5.4 May 16, 2017
@decadence
Copy link
Contributor Author

Thanks!

@decadence decadence deleted the route_isName branch May 16, 2017 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@decadence @taylorotwell