[5.4] Add make method to HasOneOrMany and MorphOneOrMany relations
#19307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a `make` method for instanciating eloquent models on `hasOne`, `hasMany`, `morphOne`, and `morphMany` relationships without performing inserts.
| { | ||
| return tap($this->related->newInstance($attributes), function ($instance) { | ||
| $instance->setAttribute($this->getForeignKeyName(), $this->getParentKey()); | ||
| }); |
There was a problem hiding this comment.
setAttribute returns the model. Why do we need the tap call?
There was a problem hiding this comment.
I just copied the create method and removed the save call. You are right, the tap is not needed, as the $instance can be chained through the setAttribute and then returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a
makemethod for instantiating eloquent models onhasOne,hasMany,morphOne, andmorphManyrelationships without performing inserts.A similar example:
This is heavily inspired from this sweet PR (#19015) from @calebporzio, who implemented a
makemethod on the query builder.