Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Fix for empty Collection #19651

Merged
merged 1 commit into from
Jun 18, 2017
Merged

[5.5] Fix for empty Collection #19651

merged 1 commit into from
Jun 18, 2017

Conversation

decadence
Copy link
Contributor

@decadence decadence mentioned this pull request Jun 17, 2017
Merged
@tillkruss tillkruss changed the title Fix for empty Collection [5.5] Fix for empty Collection Jun 17, 2017
@taylorotwell taylorotwell merged commit 3a20ea2 into laravel:master Jun 18, 2017
@decadence decadence deleted the master branch June 18, 2017 08:44
@decadence decadence restored the master branch June 18, 2017 08:44
@tillkruss
Copy link
Contributor

tillkruss commented Jun 23, 2017 •
edited
Loading

Why was this merged into master and not 5.4? Should this be back-ported?

@decadence decadence deleted the master branch June 23, 2017 18:59
@decadence
Copy link
Contributor Author

It's already done
#19671

@tillkruss
Copy link
Contributor

Ah, thanks!

@decadence
Copy link
Contributor Author

Initially I made it for master because wrongly thought this method is for 5.5 only (maybe because it was merged in master by that moment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@decadence @tillkruss @taylorotwell