Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Just use is_object() #19845

Merged
merged 2 commits into from
Jun 30, 2017
Merged

[5.4] Just use is_object() #19845

merged 2 commits into from
Jun 30, 2017

Conversation

KennedyTedesco
Copy link
Contributor

Ref: #19838

@Douglasdc3
Copy link
Contributor

Good fix although the actual change (adding support for objects) is a breaking change see

@KennedyTedesco
Copy link
Contributor Author

@Douglasdc3 Maybe we can mitigate by evaluating if the __toString() is implemented? See the new commit.

FYI: I'm just trying to fix it, I haven't a use case for it.

@taylorotwell taylorotwell merged commit 4e11ed8 into laravel:5.4 Jun 30, 2017
@KennedyTedesco KennedyTedesco deleted the 5.4-minor branch June 30, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KennedyTedesco @Douglasdc3 @taylorotwell