Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Consistent make command class names #20216

Merged
merged 1 commit into from
Jul 23, 2017
Merged

[5.4] Consistent make command class names #20216

merged 1 commit into from
Jul 23, 2017

Conversation

SamAsEnd
Copy link
Contributor

While I was surfing the code base I notice one make command class name is not consistent with the others.

I think the MakeAuthCommand should be AuthMakeCommand just to make it consistent.

screenshot from 2017-07-23 00-32-37

@SamAsEnd
Copy link
Contributor Author

@themsaid ping.

@SamAsEnd SamAsEnd changed the title consistent make command class names [5.4] Consistent make command class names Jul 23, 2017
@taylorotwell taylorotwell merged commit 6b0376e into laravel:5.4 Jul 23, 2017
@SamAsEnd
Copy link
Contributor Author

😄

@joshmanders
Copy link
Contributor

For future references, you don't need to ping anyone to get your PR noticed. They regularly go through all PR's and handle them. Going to be a bit slow this week though with laracon coming up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants