-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.5] Fix travis CI error #20329
[5.5] Fix travis CI error #20329
Conversation
.travis.yml
Outdated
@@ -34,7 +34,7 @@ services: | |||
- redis-server | |||
|
|||
before_install: | |||
- phpenv config-rm xdebug.ini | |||
- if [[ $TRAVIS_PHP_VERSION != 7.2 ]] ; then phpenv config-rm xdebug.ini; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is brittle with time. We should check if that config exists, rather than a switch on the php version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GrahamCampbell 👍 changed it
What is all this xdebug garbage? I still don't understand why it is even there AT ALL? |
It's there to disable xdebug when testing our builds, since xdebug makes the testing proccess slower we remove the config file before starting the build to disable it, however some PHP versions aren't supported by xdebug (like 7.2 for example) thus there's no file to be removed. |
But it's making our tests a lot slower having this line there because the builds end up not running at all every time something with PHP changes. |
As comment on #20258 (comment) this fixes the error on travisCI, I've sent a separate PR to fix the other internal count error for the 5.4 branch #20330.
Those 14(5.4)/22(5.5) count errors should be fixed when mockery/mockery#771 gets merged,