Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Fix make:policy Command #20645

Closed
wants to merge 1 commit into from
Closed

[5.4] Fix make:policy Command #20645

wants to merge 1 commit into from

Conversation

ahmed-aliraqi
Copy link
Contributor

When create the User policy php artisan make:policy UserPolicy -m User
will duplicate the App\User class imports

screenshot

@@ -82,6 +82,11 @@ protected function replaceModel($stub, $model)
$stub = str_replace('NamespacedDummyModel', $this->laravel->getNamespace().$model, $stub);
}

$namspaceModel = $this->laravel->getNamespace().$model;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in var name

@tillkruss tillkruss changed the title Fix make:policy Command [5.4] Fix make:policy Command Aug 20, 2017
@taylorotwell
Copy link
Member

This PR has typos.

@aik099
Copy link
Contributor

aik099 commented Aug 21, 2017

@taylorotwell , I'm wondering why are you closing PR instantly if issues are found during review process. This completely disables dialog possibility on PR code or even fixing attempt as separate commit on same PR.

Any practical reasons behind this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants