[5.5] Policy stub fixes: correct User model & var name for UserPolicy
#21499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `User $user` argument in Policy stub does not respect `auth.providers.users.model` config value. Also, `$user` variable used twice when generating Policy for User class.
|
Have you checked the use statement of the stub? I though I fixed it with this pull-reques😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
User $userargument in Policy stub does not respectauth.providers.users.modelconfig value. This PR replaces defaultUsermodel typehint with correct one from auth config (DummyUserin policy stub).Also, generated policy for
Usermodel have duplicate$uservariable in methods signature (one for authenticated user & one for poilcy model instance).With this change policy for
Usermodels will be generated with(User $user, User $model)signatures instead of(User $user, User $user).