Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.6] Fix issue with Resources when loading a single MergeValue with an associative array #23414

Merged
merged 2 commits into from
Mar 6, 2018

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Mar 6, 2018

No description provided.

@taylorotwell taylorotwell merged commit a4e414f into laravel:5.6 Mar 6, 2018
@Astyk
Copy link

Astyk commented Mar 9, 2018

Just note, that parameter '$numericKey' doesn't count anymore

@hotmeteor
Copy link
Contributor

This is a breaking change for how array keys are resolved.

array:6 [
  1 => 0
  2 => 0
  3 => 0
  4 => 0
  5 => 0
  "total" => 0
]

Before the change the above array could be returned from the resource. After, the array is formatted as:

array:6 [
  0 => 0
  1 => 0
  2 => 0
  3 => 0
  4 => 0
  5 => 0
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants