Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Remove unused method #25381

Closed
wants to merge 1 commit into from
Closed

[5.7] Remove unused method #25381

wants to merge 1 commit into from

Conversation

staudenmeir
Copy link
Contributor

#19631 removed the method call but not the method itself.

@GrahamCampbell
Copy link
Member

This may not be unused, since it's protected. People may be calling this in their apps. It seems like a pretty useful method.

@mfn
Copy link
Contributor

mfn commented Aug 30, 2018

This may not be unused, since it's protected. People may be calling this in their apps. It seems like a pretty useful method.

It's targeting the next release so it could be mention in an upgrade.

But having methods around in the framework which aren't used in the framework is… weird. Probably there are more, but still.

👍 for removing. If someone needs it, he/she can get it.

@jmarcher
Copy link
Contributor

👎 For deleting methods in immediate releases, I believe we should deprecate methods/attributes/helper functions first for one release and then delete the method on the following release.

@staudenmeir staudenmeir deleted the unused branch August 31, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants