[5.7] Fix prefixed table indexes

[laurencei]

This is an attempt to fix #7889. This issue is the oldest outstanding Laravel Framework issue at over 3.5 years old (March 2015) - so I thought I'd give it a crack. 😄

Also fixes duplicates of the original issue - #23142, #13683 and #9040

Essentially the problem boils down that the Blueprint class prepares the SQL commands without taking into account the database connection prefix. While the table prefix stuff is handled further up, we need to do the table indexes inside the Blueprint class.

This is a non-breaking and full backwards compatible change; I've set default behavior for existing projects to maintain current behavior. This is because migrations and foreign keys etc could break mid-project, so they need to maintain existing behavior unless they want to manually change.

All new projects will default to the new behavior - but it is fully configurable either way.

I've done laravel/laravel#4783 as a related PR with the new config option if this one is accepted.

[franzliedke]

@laurencei It's interesting to see you added the prefix to the Blueprint class, given that no other functions that use the prefix (such as those creating a table) add the prefix this way. Instead, they rely on the grammar classes to do so. All of those inherit from Illuminate\Database\Grammar, and use the various wrap* functions of that base class. Most importantly, wrapTable().

IMO, the fix should have been to use wrapTable() for the index name in the various compileIndex() methods of the schema grammar subclasses.

[laurencei]

@franzliedke - thanks. I did consider and look at that at the time. But for some reason I didnt think it would work. I went back and had another look - and your right, that is a better spot. I must have overlooked something the first time.

I'll submit a PR for a refactor shortly. Thanks.

[franzliedke]

@laurencei Awesome! And thanks for tackling this issue in the first place. 👍

Maybe it was harder to do the config thing in the Grammar class? If so, maybe it can be added without the config to 5.8, where breaking changes are allowed?

[ChrisThompsonTLDR]

@laurencei thanks for taking a crack on fixing this. I appreciate it and look forward to seeing this patched.

[franzliedke]

@laurencei Have you had any luck with that refactoring? 🙈

[laurencei]

It's on my "todo" list.

I would technically be a breaking change - so it'll have to go to 5.8.

I'll try and get to it next week...

[franzliedke]

It would be a refactoring affecting only internal classes and no contracts. Why do you consider that breaking? Laravel has always been quite loose about that...