[5.7] Insufficient permissions on packages.php #26232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tempnam()` creates files with permissions set to 600, so we fix it by just removing the temp file created by `tempnam()`.
Yogarine
changed the title
Yogarine
changed the title
|
@taylorotwell |
|
As mentioned in the revert PR, this fix should target 5.8, if accepted. |
That was a suggestion made before it was clear that this was the actual fix. This issue was caused by an oversight when using |
|
Taylor doesn't like to play trial and error. If something breaks production code, first it needs reverting and then re-examination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #26230
tempnam()creates files with permissions set to 600, so we fix it byjust removing the temp file created by
tempnam().The alternative is to change permissions after creating the file, but that might not always be possible and also means we would have to figure out what the current
umask()is to do it consistent with the umask.