[5.7] Add orWhere proxy for scopes to Eloquent Builder #27281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a shorter way of combining Model query scopes using the same technique applied in Laravel's Collections. Currently, combining model scopes with an
OR
operator adds more complexity in than necessary.This PR allows chaining of
OR
's without the Closure in user code, like so.It follows the same logic as combining regular
where
andorWhere
. The following code examples are thus considered equivalent.Considerations
This PR does not break any existing functionality as far as I know.
I have considered another approach to achieve the same simplicity. It would add the possibility to call query scopes prepended with
or
, like so. But to my knowledge, this seemed more confusing than the proposed change.