[5.8] Make updateExistingPivot() safe on non-existent pivot #29362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue from [5.8] Fix many to many sync results with custom pivot model by themsaid · Pull Request #28416 · laravel/framework.
Currently, when we use
updateExistingPivot()
with a custom pivot class, the following code will be executed.However, it is unsafe; If we call
updateExistingPivot()
for non-existent record, it will unexpectedly causeFatalThrowableError
.This PR resolves this issue by fixing like this: