[6.x] Prevent event autodiscovery from crashing when trying to instantiate files without classes #29895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files that are not classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you store other files than php classes in a folder where the autodiscovery mechanism looks for listeners, it will crash because of a reflection error when trying to instantiate the reflection class. I think that these exceptions should be caught and ignored, just like the code ignores classes which are not instantiatable.
The exception can be seen by running the current autodiscovery test (without the try-catch block present) when a non-php class file is present in the fixture folder. I've added a empty js file as an example to the test fixture to make sure the test passes when other files are present in the discovery directory.