[6.x] Allow to use scoped macro in nested queries

[dkulyk]

Sometimes need to use scope macro in nested queries:

Model::query()->where(function (Builder $query) {
    $query->withoutTrashed()
        ->orWhereDate('created_at', '>', Carbon::now()->subMonth());
})->withTrashed();

//Real example:
Access::query()
    ->where('type', 'free')
    ->orWhere(function (Builder $query) {
        $query
            ->where('type', 'protected')
            ->forUser(Auth::user()); //scoped macro with nested logic
    })

Scopes are applying only when you call get() or cursor(). But In nested queries this not happening.

I believe this is bug what scope macro does not work in nested queries.

[staudenmeir]

We can't use newQuery(), it adds $withCount and its bindings to the nested query (#24240).

[dkulyk]

I'll explore this. But where are test for it?

[dkulyk]

newQueryWithoutRelationships does what is needed.

[staudenmeir]

Sorry, you can use newQuery(). I forgot the binding issue has also been fixed (and tested) in #24000.

[dkulyk]

Sorry, you can use newQuery(). I forgot the binding issue has also been fixed (and tested) in #24000.

Cannot. I catch Error: Maximum function nesting level of '256' reached, aborting! if Model has non empty $withCount

[derekmd]

256 is xdebug's default stack depth limit in local development. Disabling the PHP extension will also make the test suite run much faster.

[GrahamCampbell]

@derekmd The most likely reason one would encounter that error is if there was infinite recursion in the call. It's unlikely that the stack depth limit was hit, otherwise. Disabling the extension would likely see php segfault instead.