Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Remove unnecessary param passed to updatePackageArray method #30155

Merged
merged 1 commit into from
Oct 2, 2019
Merged

[6.x] Remove unnecessary param passed to updatePackageArray method #30155

merged 1 commit into from
Oct 2, 2019

Conversation

danielmadu
Copy link
Contributor

The updatePackageArray function has only one param in all classes tha use it, but the function updatePackages from the Preset class are passing two params to the parent function.

@taylorotwell taylorotwell merged commit 2b7db5f into laravel:6.x Oct 2, 2019
@danielmadu danielmadu deleted the remove-param branch October 2, 2019 17:35
i-bajrai pushed a commit to i-bajrai/framework that referenced this pull request Oct 4, 2019
@danielmadu @i-bajrai
Removed unnecessary param passed to updatePackageArray method (larave…
6c318d4 
…l#30155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmadu @taylorotwell